Overlap count not accurate

bentsai · December 16, 2021, 9:26pm

I have three cards overlapping, but the counter only says two. It seems like the detection is not accounting for the extra height of the middle card due to the line breaks?

https://kinopio.club/freckle-seeker-vH7nzZXPAdBFPGZGwLZwf

bentsai · December 16, 2021, 10:01pm

Maybe I don’t understand the algorithm. I would expect this to be 3 as well:

stegriff · December 17, 2021, 4:10pm

Collisions are hard

pirijan · December 17, 2021, 5:38pm

sadly yes they are – especially calculating them in real time without tanking performance

pirijan · December 28, 2021, 5:01pm

thx to this i found a bug/typo in the overlap calc, now this situation correctly returns

pirijan · December 28, 2021, 5:05pm

if ur curious this my overlap code, it runs in a webworker and is triggered to update when you do stuff like scroll or interact with a card

gist.github.com

https://gist.github.com/pketh/f306da652156eeccc1355505d391cdae

card-overlaps.js

// group cards into overlap groups

self.onmessage = function (event) {
  const offset = 10
  const { cards, viewport, zoom } = event.data
  let newCards = cards.filter(card => isCardInViewport(card, viewport, zoom))
  newCards = newCards.map(card => {
    return {
      id: card.id,
      name: card.name,

This file has been truncated. show original

bentsai · January 6, 2022, 1:09am

It seems like the overlap code thinks these cards are bigger than they are rendered here. (Kinopio – Thinking Canvas). It feels like there’s a race condition where the overlap code is running before the kinopio space “preview” gets tidied up, hence the larger assumed card size and higher overlap count.

Other reports of bugs with overlap count: https://futureland.tv/ethan/entry/136533?fullscreen=1

pirijan · January 6, 2022, 3:47am

Yes that’s because card dimensions are not being recalculated after the spacelink data is ready

pirijan · January 24, 2022, 3:26pm

fix released, let me know how it is now